fix: use portable ioctl request codes#63
Conversation
|
Pull request updated with integration test change. Running |
|
I see the build error and am a bit embarrassed. Turns out the Apple specific code was needed, precisely like the comment said. I was sloppy to assume that An updated branch has been pushed. |
|
@rymdbar no biggie at all! Looking again now. |
|
Oh. I forgot about the integration tests duplicating the constants, and didn't realize to run zigfmt. Will push an update in a few minutes. |
|
I'm having trouble with integration tests failing, even with the same commit which I experienced was working earlier. My train is arriving its station now, so I'll need to get back to it later. |
|
Seems my problem with integration test was that I accidentally ran them inside another boo session. When running them in a plain terminal, they work. 🙂 |
|
@rymdbar heh ;p |
Using the constants under the `std.c` prefix rather than under `std.os.` works on more platforms. This change can make the compile fail with an actual error rather than "unsupported OS" on obscure platforms, but it should be safe to assume anyone building on such niche systems prefers this.
|
Repushed unchanged, after being rebased onto latest main. |
|
Once CI passes I'll merge! |
While Zig's std does not set these variants for darwin under
std.os., they are available with the exact same values understd.c. Thus there seems to be no reason to not use the portable constants.