Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions fixit/bases.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
"""Number base conversion helpers."""


def to_bases(number: int) -> str:
"""Return a non-negative integer as binary, octal and hexadecimal.

Example:
to_bases(255) returns "0b11111111 0o377 0xff".

Raises:
ValueError: if number is negative.
"""
if number < 0:
raise ValueError("Error: only non-negative integers are supported")
return f"{bin(number)} {oct(number)} {hex(number)}"
13 changes: 12 additions & 1 deletion fixit/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

from fixit import (
__version__,
bases,
coin,
convert,
health,
Expand Down Expand Up @@ -164,6 +165,11 @@ def run_fizzbuzz(args: argparse.Namespace) -> None:
for item in fizzbuzz.fizzbuzz(args.n):
print(item)


def run_base(args: argparse.Namespace) -> None:
"""Print a number in binary, octal and hexadecimal."""
print(bases.to_bases(args.number))

COMMAND_TABLE = {
"wc": run_wc,
"convert": run_convert,
Expand All @@ -182,7 +188,7 @@ def run_fizzbuzz(args: argparse.Namespace) -> None:
"coin": run_coin,
"bmi": run_bmi,
"fizzbuzz": run_fizzbuzz,

"base": run_base,

}

Expand Down Expand Up @@ -280,6 +286,11 @@ def build_parser() -> argparse.ArgumentParser:
fb = sub.add_parser("fizzbuzz", help="print FizzBuzz sequence up to n")
fb.add_argument("n", type=int, help="upper limit (must be at least 1)")

base = sub.add_parser(
"base", help="show a non-negative integer in binary, octal and hex"
)
base.add_argument("number", type=int, help="non-negative integer")

return parser


Expand Down
31 changes: 31 additions & 0 deletions tests/test_bases.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
import pytest

from fixit import bases
from fixit.cli import main


def test_to_bases_example():
assert bases.to_bases(255) == "0b11111111 0o377 0xff"


def test_to_bases_zero():
assert bases.to_bases(0) == "0b0 0o0 0x0"


def test_to_bases_negative_raises():
with pytest.raises(ValueError):
bases.to_bases(-1)


def test_base_command(capsys):
result = main(["base", "255"])

assert result == 0
assert capsys.readouterr().out.strip() == "0b11111111 0o377 0xff"


def test_base_command_rejects_negative(capsys):
result = main(["base", "-5"])

assert result == 1
assert "non-negative" in capsys.readouterr().err
Loading