Repository navigation
Biometrics: report KEY_REVOKED when re-enrolment removes or invalidates the key - #6221
Open
shai-almog wants to merge 1 commit into
Open
shai-almog wants to merge 1 commit into
shai-almog wants to merge 1 commit into
Conversation
…es the key Android deletes a biometric-bound keystore key when every biometric is removed, so a later read found no key and failed as UNKNOWN. On iOS an item bound to the current Face ID/Touch ID set answers errSecItemNotFound after re-enrolment, which also mapped to UNKNOWN; iOS never reported KEY_REVOKED. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Compared 195 screenshots: 195 matched. Native Android coverage
✅ Native Android screenshot tests passed. Native Android coverage
Benchmark ResultsDetailed Performance Metrics
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A biometric secure-storage read after the user removed every biometric, or re-enrolled Face ID / Touch ID, failed as
BiometricError.UNKNOWNinstead ofKEY_REVOKED, so apps could not tell a re-enrolment from an error.AndroidSecureStorage.getSecretKey): Android deletes a biometric-bound key when every biometric is removed.get()returns before the decrypt path when nothing is stored, so a missing key there means an entry whose key was taken away: nowKEY_REVOKED.IOSNative.m,IOSSecureStorage): an item bound tokSecAccessControlTouchIDCurrentSetanswerserrSecItemNotFoundto a data read after the enrolled set changes, while an attributes-only query (no ACL, no prompt) still finds it. That combination now reportsKEY_REVOKED(a non-OSStatus code,-990001) and deletes the unreadable item, as Android deletes its invalidated key. iOS previously never reportedKEY_REVOKED.🤖 Generated with Claude Code