-
Notifications
You must be signed in to change notification settings - Fork 434
Report the real port status, and fix the desktop-port defects it was hiding #5501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
95 commits
Select commit
Hold shift + click to select a range
aad27d0
Report the real port status, and fix the desktop-port defects it was …
shai-almog 3c58dcc
Address review: validate before publishing, wire the suite gate, fix …
shai-almog a2cb05f
Fix the desktop-port file paths the louder IO errors exposed
shai-almog 8dd4c6a
Implement the desktop crypto bridge, and fix the shared UTF-8 buffer …
shai-almog 7cb8f3e
Name the test that wedges the suite instead of letting the run die qu…
shai-almog 0c6c970
Give the Windows port real named-time-zone offsets
shai-almog 19255eb
Report the wedging test through the harness, not a forbidden exit call
shai-almog 902b535
Address the second review round across crypto, time zones and the sweep
shai-almog 81fe244
Pad OAEP in the Windows port and encode ECDSA signatures as DER
shai-almog 9ef1a7b
Pad OAEP in the Windows port and encode ECDSA signatures as DER
shai-almog 879f159
Resolve Windows ICU at runtime so the clean target still links
shai-almog e04582e
Keep the wedge watchdog off the JavaScript port
shai-almog 887e31c
Keep the Windows natives and the runner's lambda numbering intact
shai-almog 3eee8ab
Address the third review round: OAEP, ECDSA DER and shared error state
shai-almog 4244c0c
Deliver a health result on the EDT even to a listener that arrives late
shai-almog e78fa04
Address the fourth review round, and the health delivery fix's last c…
shai-almog 880bc28
Give the Linux browser its JS bridge instead of navigating to codenam…
shai-almog 445dfd3
Give LinuxBrowserComponent a copyright header and an accurate descrip…
shai-almog 29dc949
Stop the browser test from accepting a blank frame as a rendered page
shai-almog 9c37773
Add the Linux golden for the browser test's surrounding form
shai-almog d4da95c
Add the arm64 golden for the browser test
shai-almog fc39076
Refuse crypto names outside the advertised set, and read the raw offs…
shai-almog eeb59d1
Make a documented skip prove itself, and compare timestamps as instants
shai-almog 2ff146c
Document encoder skips per port instead of failing the Apple runs
shai-almog 1b30b06
Honour the requested UI-settle budget, and say when it runs out
shai-almog a3bbdd0
Keep identifier-ignorable characters out of identifier starts
shai-almog 6e05a5c
Align the iOS OAEP mask with every other port, and check the key fami…
shai-almog e8bf68e
Require the exact key family, and let a dispatched run repair a stale…
shai-almog 0f7eed2
Arm the Linux gates that were letting unrun tests pass as success
shai-almog 3d4051f
Stop a closed MCP transport from stranding the process-wide registration
shai-almog 34087aa
Name the test the Linux suite stops in
shai-almog 5cdb9cc
Decide the MCP listener publication under the lock close() uses
shai-almog fb754a9
Remove the in-process wedge watchdog that deadlocked the Linux suite
shai-almog 9ce6695
Standardise OAEP on SHA-256 for both halves, the only pairing every p…
shai-almog 5d14fc4
Put getTimezoneOffset back on UTC fields, and match the OAEP name exa…
shai-almog ee68937
Mark each stage of a test's dispatch so a dead suite says where it st…
shai-almog 63a2a31
Give the Linux suite the time its repaired tests now need
shai-almog f53b1bd
Line-buffer the generated main's stdout so a killed run's log is not …
shai-almog 7d0ad8c
Ask Gradle for the stack when Android packaging fails
shai-almog 39fa46b
Use _IONBF: the MSVC CRT fail-fasts on a line-buffered request
shai-almog a70e121
Revert the timeout inflation; my own evidence had already disproved it
shai-almog 7f440dd
Photograph the Linux stall while it is stalled, not once it has settled
shai-almog af9944c
Separate each stall sample with a timestamped header
shai-almog 1092abd
Address the review round: OAEP key sizes, DER strictness, verify erro…
shai-almog 2d07450
Run every GtkClipboard call on the GTK main thread
shai-almog c3d1c98
Keep publishing the Linux port status when the suite fails
shai-almog 6ff6b69
Serialise the iOS path-renderer's process-wide setup
shai-almog 3213bd3
Fix the sweep's jq invocation and a rejected-transformation key leak
shai-almog 427c4ee
Publish a crashed suite's report instead of rejecting it
shai-almog 99e9561
Close out the Copilot findings I had not been reading
shai-almog af48232
Work the rest of the Copilot backlog, not just the newest review
shai-almog 54c3aba
Match the JDK's custom time-zone IDs, and three more review findings
shai-almog f26f73d
Keep close() synchronous while still retiring an in-flight bind
shai-almog 68d317d
Give the Android packager enough heap to package the app
shai-almog 7a977f9
Credit each port's report to the run it actually came from
shai-almog dc68495
Close the review round: bind window, verify errors, and stale-report …
shai-almog 11dd24b
Round the RSA modulus up, and answer GMT for noncanonical bare zone IDs
shai-almog 2692acd
Save the capture before asserting it is complete
shai-almog 4633251
Report CNG verification errors, and fail on misidentified reports
shai-almog 6a5cf3f
Refuse the MCP slot for a transport that is already closed
shai-almog 5ecec70
Carry the log-only and unreadable-report handling into the Windows paths
shai-almog 5e520a3
Report a newest run with no artifact, and make publication a real CAS
shai-almog 3eeda2b
Validate the missing field, catch omitted ports, always rebuild the site
shai-almog 819fd29
Merge master
shai-almog 55104cc
Resolve TimeZone.getOffset in the frame its callers actually use
shai-almog fff82c4
Reject AAD outside AES-GCM, and report frames when the port has no stack
shai-almog d384a68
Merge remote-tracking branch 'origin/master' into fix-port-status-parity
shai-almog b7e1821
Merge master, and instrument the Windows Switch failure
shai-almog dc74eb9
Add the missing copyright header to KotlinUiTest
shai-almog 4cfec9f
Merge master
shai-almog f675b2f
Reject ECB IVs, sweep timed-out runs, and instrument the rest of Kotl…
shai-almog 26234d6
Stop the EDT harness discarding its own dispatches, and retry stalled…
shai-almog d55ae23
Add the missing copyright headers to the EDT test harness
shai-almog 4d4d42a
Merge remote-tracking branch 'origin/master' into fix-port-status-parity
shai-almog 15bfffb
Bisect the Windows Accordion.addContent failure
shai-almog 6f02a35
Probe on a throwaway Accordion, not the rendered one
shai-almog 6615b01
Narrow the Windows NPE further, and back off properly on a 429
shai-almog c0e4c6c
Rename within the folder on Windows, as the contract says
shai-almog dedc1fc
Select the audio stream on Windows, and split the Switch probe
shai-almog c8644d5
Report why Media Foundation yields no audio, and name the throwing ac…
shai-almog 8175b20
Read Windows audio from its own reader; stop handing back a 0 image peer
shai-almog 378c948
Drop the clamp, and report the metrics that explain these NPEs
shai-almog 214286a
Fix the cross-compile I broke, and probe the image primitives
shai-almog 4aab910
Probe the ImageFactory path and an OFF switch's preferred size
shai-almog 89590b3
Narrow the Switch NPE to the ON thumb's blur branch
shai-almog 27121ff
Probe getWidth on the blurred image
shai-almog dfc918e
Name the failing image in Switch, and count audio samples written
shai-almog eb0c848
Give the Windows blur a drawable result, encode audio at a rate MF ac…
shai-almog 2eaad06
Replace the Switch bisect probes with the check that would have caugh…
shai-almog b948cd0
Seed the three Windows goldens the Switch fix unblocked
shai-almog 6559b6c
Close the thirteen open review threads
shai-almog 86cfcb5
Chunk long Windows waits, and pin the lowercase custom-zone contract
shai-almog 7ee0e19
Stop PR jobs building a deploy action they never run
shai-almog c724f5a
Stop a wrong-key RSA verify being reported as a broken verifier
shai-almog 5ed6c4a
Fix the four new review findings, including a wait bug my last fix mi…
shai-almog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.