Fix ConcurrentModificationException in GeofenceManager expiry purge

[shai-almog]

Motivation

• Iterating expiryTimes.entrySet() while removing expired entries caused a ConcurrentModificationException during GeofenceManager updates and construction, so the purge logic needed to stop mutating the map via the enhanced-for loop.

Description

• Change GeofenceManager.purgeExpired() to iterate the expirations map with an explicit Iterator and call it.remove() when an entry is expired to avoid concurrent modification.
• Add a regression test updatePurgesExpiredGeofencesWithoutConcurrentModification to GeofenceManagerTest that injects expired entries and asserts manager.update(...) does not throw and removes the expired geofences from tracked state.
• Add a small reflective test helper setPrivateField used by the new test to set expiryTimes deterministically.

Testing

• Ran the targeted unit tests with Java 8 using export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64; export PATH="$JAVA_HOME/bin:$PATH"; cd maven && mvn -pl core-unittests -am -DunitTests=true -Dmaven.javadoc.skip=true -Dtest=GeofenceManagerTest -DfailIfNoTests=false test and the GeofenceManagerTest suite passed (9 tests, 0 failures).
• The Maven invocation produced existing project warnings about local systemPath artifacts but the targeted tests succeeded and the build completed with BUILD SUCCESS.

---

Codex Task

[github-actions]

✅ Continuous Quality Report

Test & Coverage

• ✅ Tests: 2313 total, 0 failed, 0 skipped
• 📊 Line coverage: 53.17% [HTML preview] [Download]
  • Lowest covered classes
    • com.codename1.ui.Display$EdtException – 0.00%
    • com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
    • com.codename1.util.EasyThread$InQueueRunnable – 0.00%
    • com.codename1.components.FloatingActionButton$ReleaseActionListener – 0.00%
    • com.codename1.io.Oauth2$RefreshTokenActionListener – 0.00%
    • com.codename1.util.EasyThread$RunAndWaitRunnable – 0.00%
    • com.codename1.components.ToastBar$FlushAnimationCallback – 0.00%
    • com.codename1.ui.plaf.CSSBorder$ColorStop – 0.00%
    • com.codename1.ui.ElevationComparator – 0.00%
    • com.codename1.ui.spinner.TimeSpinner3D$MinuteRowFormatter – 0.00%

Static Analysis

• SpotBugs [HTML preview] [Download]
  • ❌ ByteCodeTranslator: 97 findings (High: 2, Normal: 68, Low: 27)
    • Top findings
      • High: com/codename1/tools/translator/BytecodeMethod.java:559 – Method com.codename1.tools.translator.BytecodeMethod.findWritableFields(Set) seems to be useless (rule: UC_USELESS_VOID_METHOD)
      • High: com/codename1/tools/translator/bytecodes/TryCatch.java:75 – Write to static field com.codename1.tools.translator.bytecodes.TryCatch.hasTryCatch from instance method com.codename1.tools.translator.bytecodes.TryCatch.appendInstruction(StringBuilder, List) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
      • Normal: com/codename1/tools/translator/ByteCodeClass.java:1791 – com.codename1.tools.translator.ByteCodeClass.getBaseClassObject() may expose internal representation by returning ByteCodeClass.baseClassObject (rule: EI_EXPOSE_REP)
      • …and 94 more
  • ❌ android: 412 findings (High: 24, Normal: 196, Low: 192)
    • Top findings
      • High: CodenameOne/src/com/codename1/impl/CodenameOneThread.java:48 – com.codename1.impl.CodenameOneThread.STACK_FRAME_SIZE isn't final but should be (rule: MS_SHOULD_BE_FINAL)
      • High: com/codename1/impl/android/AndroidImplementation.java:1067 – Write to static field com.codename1.impl.android.AndroidImplementation.context from instance method com.codename1.impl.android.AndroidImplementation.setContext(Context) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
      • High: com/codename1/impl/android/AndroidImplementation.java:1268 – com.codename1.impl.android.AndroidImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
      • …and 409 more
  • ❌ codenameone-maven-plugin: 477 findings (High: 1, Normal: 313, Low: 163)
    • Top findings
      • High: com/codename1/maven/AbstractCN1Mojo.java:807 – com.codename1.maven.AbstractCN1Mojo.OS isn't final but should be (rule: MS_SHOULD_BE_FINAL)
      • Normal: com/codename1/builders/AndroidGradleBuilder.java:1018 – Dead store to googleServicesJson in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) (rule: DLS_DEAD_LOCAL_STORE)
      • Normal: com/codename1/builders/AndroidGradleBuilder.java:1043 – Possible null pointer dereference in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) due to return value of called method (rule: NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE)
      • …and 474 more
  • ❌ core-unittests: 1 findings (Normal: 1)
    • Top findings
      • Normal: CodenameOne/src/com/codename1/ui/util/MutableResource.java:239 – com.codename1.ui.util.MutableResource.saveL10N(DataOutputStream, Hashtable) makes inefficient use of keySet iterator instead of entrySet iterator (rule: WMI_WRONG_MAP_ITERATOR)
  • ❌ ios: 125 findings (High: 4, Normal: 75, Low: 46)
    • Top findings
      • High: com/codename1/impl/ios/IOSImplementation.java:1223 – com.codename1.impl.ios.IOSImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
      • High: com/codename1/impl/ios/IOSImplementation.java:128 – com.codename1.impl.ios.IOSImplementation.nativeInstance isn't final but should be (rule: MS_SHOULD_BE_FINAL)
      • High: com/codename1/impl/ios/IOSImplementation.java:214 – Write to static field com.codename1.impl.ios.IOSImplementation.instance from instance method com.codename1.impl.ios.IOSImplementation.init(Object) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
      • …and 122 more
• ✅ PMD: 0 findings (no issues) [Report archive]
• ✅ Checkstyle: 0 findings (no issues) [Report archive]

Generated automatically by the PR CI workflow.

[shai-almog]

Android screenshot updates

Compared 32 screenshots: 31 matched, 1 updated.

• landscape — updated screenshot. Screenshot differs (640x320 px, bit depth 8).

  
  Preview info: Preview provided by instrumentation.
  Full-resolution PNG saved as landscape.png in workflow artifacts.

Native Android coverage

• 📊 Line coverage: 7.31% (3719/50867 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
  • Other counters: instruction 5.71% (18267/320093), branch 2.75% (857/31113), complexity 3.42% (1016/29746), method 6.03% (835/13858), class 9.83% (180/1831)
  • Lowest covered classes
    • kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
    • kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
    • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
    • kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
    • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
    • kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/712 lines covered)
    • kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
    • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
    • kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
    • kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

[shai-almog]

iOS screenshot updates

Compared 32 screenshots: 31 matched, 1 updated.

• landscape — updated screenshot. Screenshot differs (2556x1179 px, bit depth 8).

  
  Preview info: Preview provided by instrumentation.
  Full-resolution PNG saved as landscape.png in workflow artifacts.

Benchmark Results

• VM Translation Time: 290 seconds
• Compilation Time: 164 seconds

Detailed Performance Metrics

Metric	Duration
Build Time Statistics
Setup & Unzip	22725 ms
Extract Extensions	13 ms
Google Services Setup	1 ms
Scan Classes	462 ms
Extract Libs	761 ms
Inject Build Hints	33 ms
Generate Unit Tests	3 ms
Generate Stubs	850 ms
Compile Stubs	1918 ms
Generate Icons	738 ms
Prepare ParparVM	143 ms
ParparVM Execution	183165 ms
Post-VM Setup	218 ms
CocoaPods	3881 ms
Finalize	22 ms
Total Time	214934 msMaven Overhead : 76000 ms
CocoaPods Install (Script)	1000 ms
Simulator Boot	66000 ms
Simulator Boot (Run)	3000 ms
App Install	15000 ms
App Launch	4000 ms
Test Execution	134000 ms