Add Advanced CSS editor to Initializr theme customization#4580
Closed
shai-almog wants to merge 3 commits intomasterfrom
Closed
Add Advanced CSS editor to Initializr theme customization#4580shai-almog wants to merge 3 commits intomasterfrom
shai-almog wants to merge 3 commits intomasterfrom
Conversation
Cloudflare Preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MutableResource+CSSThemeCompilerflow) and see live UI preview updates in the initializer preview pane.Description
ThemeEditorModeandcustomCsstoProjectOptionsand thread editor mode and CSS through the initializer state model so options include editor mode and CSS content (scripts/initializr/common/src/main/java/com/codename1/initializr/model/ProjectOptions.java).Editortoggle (SIMPLE/ADVANCED), keep existing controls in simple mode, and show a multiline CSSTextAreawith a starter stylesheet in advanced mode (scripts/initializr/common/src/main/java/com/codename1/initializr/Initializr.java).CSSThemeCompilerinto aMutableResource, then merging parsed theme props intoUIManagerwithaddThemePropsso changes are reflected in the preview (scripts/initializr/common/src/main/java/com/codename1/initializr/ui/TemplatePreviewPanel.java).Testing
cd scripts/initializr && ./mvnw -pl common test -DskipTests=falsewhich failed in this environment due to network error while the Maven wrapper attempted to download the Maven distribution (java.net.SocketException: Network is unreachable).cd scripts/initializr && mvn -pl common -DskipTests compile -owhich failed because required plugin artifacts were not available in the local cache (missingmaven-antrun-plugin:3.1.0).http://localhost:8080so the screenshot attempt returnednet::ERR_EMPTY_RESPONSE.Codex Task