Repository navigation
refactor: remove @see test annotations in source - #10624
Merged
paulbalandan merged 1 commit intoOct 13, 2026
Merged
Conversation
3 of 5 tasks
michalsn
approved these changes
Oct 12, 2026
paulbalandan
force-pushed
the
remove-see-test-annotations
branch
from
October 13, 2026 05:56
138c083 to
b8baef1
Compare
@see test annotations in source with #[CoversClass] in tests@see test annotations in source
Member
Author
|
I have updated this PR to just remove the annotation in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the
@see \CodeIgniter\...Testannotation from the class docblock of 127 classes undersystem/.The annotations were introduced in #7904 as a side effect of switching Rector to
PHPUnitSetList::PHPUNIT_CODE_QUALITY, whoseAddSeeTestAnnotationRectorgenerated them. They were never discussed in that PR. Rector has since dropped the rule from the set (rectorphp/rector-phpunit#343), so it is opt-in now and nothing in our Rector config would reintroduce the lines. A dry run over the touched files confirms this.Reasons to drop the convention:
Adding
#[CoversClass]to the referenced tests was tried in an earlier revision and reverted: PHPUnit then credits each test only with its named class, which zeroed the coverage of collaborators such as exception classes, language files and theCastclasses. Covers metadata will be added per component in follow-ups, with full target lists, beforerequireCoverageMetadatais enabled.4.8carries nine more annotations on classes that do not exist ondevelop; they are handled in a separate PR.Checklist: