Send logged-out users to login when clicking Follow#2143
Open
c-tonneslan wants to merge 1 commit into
Open
Conversation
The Follow buttons on the testimony detail page (and elsewhere) silently no-op'd if a logged-out visitor clicked them: the underlying setDoc runs against /users/undefined/... and Firestore rules reject it. Push the visitor through the same /login?redirect= flow other auth-gated actions use so they end up back on the page they were on. Closes codeforboston#2059 Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
c-tonneslan
requested review from
Mephistic,
alexjball,
kiminkim724,
mertbagt,
mvictor55,
nesanders,
sashamaryl and
timblais
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2059.
Clicking 'Follow H.54' (or any
FollowButtonvariant) while logged out just looked broken:setDocran against/users/undefined/activeTopicSubscriptions/...and the security rules quietly rejected it, so the visitor saw nothing.Pushed the same
/login?redirect=...flow thatrequireAuthalready uses, so the visitor signs in and lands back on the testimony (or bill / profile / ballot question) page they came from.