Skip to content

Fix Notion reconnect prompt after app restart - #218

Open
aseembits93 wants to merge 1 commit into
mainfrom
fix/persist-macos-notion-credential
Open

Fix Notion reconnect prompt after app restart#218
aseembits93 wants to merge 1 commit into
mainfrom
fix/persist-macos-notion-credential

Conversation

@aseembits93

Copy link
Copy Markdown
Collaborator

Summary

  • verify macOS Keychain writes with an uncached read before caching or accepting the connection
  • clear stale in-process credentials before writes so failed persistence cannot look healthy until restart
  • distinguish a genuinely missing Keychain item from locked/unavailable Keychain failures
  • document durable credential verification as a reliability invariant

Tests

  • cargo test -p locality-store
  • cargo test -p locality-store credentials::tests --lib
  • cargo test -p locality-desktop desktop_snapshot_marks_missing_credential_as_reconnect_needed_without_losing_mount --bin locality-desktop
  • cargo test -p loc-cli --test connect connect_notion -- --nocapture
  • cargo fmt --all -- --check
  • git diff --check

Notes

A strict workspace Clippy run is currently blocked by pre-existing warnings outside this change, beginning with crates/locality-core/src/conflict.rs:307 and existing locality-store/src/sqlite.rs warnings.

@vercel

vercel Bot commented Aug 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
locality Ready Ready Preview Aug 19, 2026 8:01pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant