Skip to content

Fix BDD step definitions to wait for recorder promise chain #5445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fijijavis wants to merge 1 commit into
base: 3.x
Choose a base branch
from
+3 −0
Open

Fix BDD step definitions to wait for recorder promise chain #5445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/mocha/gherkin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ const Gherkin = require('@cucumber/gherkin')
const Messages = require('@cucumber/messages')
const { Context, Suite } = require('mocha')
const debug = require('debug')('codeceptjs:bdd')
const recorder = require('../recorder')

const { enhanceMochaSuite } = require('./suite')
const { createTest } = require('./test')
Expand Down Expand Up @@ -83,9 +84,11 @@ module.exports = (text, file) => {
try {
debug(`Step '${step.text}' started...`)
await fn(...fn.params)
await recorder.promise()
debug('Step passed')
step.status = 'passed'
} catch (err) {
await recorder.promise()
debug(`Step failed: ${err?.message}`)
step.status = 'failed'
step.err = err
Expand Down
Loading