Skip to content

fix: Make sure that StatusUpdateTrigger and InfoUpdateTrigger keep running on rolling updates - #5663

Open
cdprete wants to merge 3 commits into
codecentric:masterfrom
cdprete:fix/triggers-rolling-updates
Open

cdprete wants to merge 3 commits into
codecentric:masterfrom
cdprete:fix/triggers-rolling-updates

Conversation

@cdprete

@cdprete cdprete commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Fixes #5450 (comment).

Better titles are welcome :D

If approved and merged, it would be great to have this released as soon as possible.
I'm currently running in DEV with a patched local version (the one in this PR) and in QA&PROD I had to destroy and recreate the deployment to re-trigger the fetching of the instances, therefore those envs are good until one Pod dies or if I've to redeploy something.

@cdprete
cdprete requested a review from a team as a code owner September 8, 2026 14:07
@cdprete

cdprete commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

HI @SteKoe @ulischulte @hzpz,
can we have this reviewed as soon as possible? Thanks in advance.

@SteKoe SteKoe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three risk findings from the review — all addressed with concrete suggestions inline.

@cdprete

cdprete commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

Three risk findings from the review — all addressed with concrete suggestions inline.

Thanks. I added my comments to them.

Btw, a better version would be to have IntervalTrigger have an Hazelcast IMap as well, so that not even the repull of the statuses and infos would be necessary, but that would require way more refactoring and I'm not certain (to try out somehow) it can be introduced in a non-breaking way.

@SteKoe What's your opinion on this?

@cdprete
cdprete force-pushed the fix/triggers-rolling-updates branch 2 times, most recently from b551aea to d5f414d Compare September 18, 2026 10:13
@cdprete
cdprete requested a review from SteKoe September 18, 2026 10:14
@cdprete
cdprete force-pushed the fix/triggers-rolling-updates branch from d5f414d to 468b3fd Compare September 18, 2026 10:15
@cdprete

cdprete commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

@SteKoe unless you want to consider #5663 (comment), all the comments have been addressed.

@cdprete
cdprete force-pushed the fix/triggers-rolling-updates branch from 468b3fd to fd799ad Compare September 18, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: UI health state doesn't reflect the latest state

2 participants