-
Notifications
You must be signed in to change notification settings - Fork 3.1k
feat(#5352): healthgroups endpoint #5416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ulischulte
wants to merge
9
commits into
master
Choose a base branch
from
feature/5352-healthgroups-endpoint
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0b7d88c
#5352: Cache health groups and expose via health-groups endpoint
ulischulte c33b00f
#5352: Cleanup health groups cache
ulischulte 6f7a20c
Merge branch 'master' into feature/5352-healthgroups-endpoint
ulischulte 3b5780e
Merge branch 'master' into feature/5352-healthgroups-endpoint
ulischulte 8b88d3e
Update spring-boot-admin-server/src/main/java/de/codecentric/boot/adm…
ulischulte 29d10f7
Fix renaming of method
ulischulte 20c2edc
#5352: Define interface for HealthGroupsCache
ulischulte 56236db
#5352: Re-fetch the (server-cached) group list on every instance change
ulischulte fa4bcf7
Merge branch 'master' into feature/5352-healthgroups-endpoint
ulischulte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
...min-server/src/main/java/de/codecentric/boot/admin/server/services/HealthGroupsCache.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| /* | ||
| * Copyright 2014-2025 the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package de.codecentric.boot.admin.server.services; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| import de.codecentric.boot.admin.server.domain.values.InstanceId; | ||
|
|
||
| /** | ||
| * Cache for health groups per instance. | ||
| */ | ||
| public interface HealthGroupsCache { | ||
|
|
||
| /** | ||
| * Update the health groups for an instance. If groups is null or empty, the entry is | ||
| * removed from the cache. | ||
| * @param instanceId the instance id | ||
| * @param groups the health groups list | ||
| */ | ||
| void updateGroups(InstanceId instanceId, List<String> groups); | ||
|
|
||
| /** | ||
| * Get the health groups for an instance. | ||
| * @param instanceId the instance id | ||
| * @return the list of health groups, or an empty list if none are cached | ||
| */ | ||
| List<String> getGroups(InstanceId instanceId); | ||
|
|
||
| /** | ||
| * Remove the health groups entry for an instance. | ||
| * @param instanceId the instance id | ||
| */ | ||
| void remove(InstanceId instanceId); | ||
|
|
||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ulischulte.
Will this assignment trigger a UI re-rendering?
If it's so, we should maybe check the content of the response first and set the new state (health groups + reset of state of the accorditions) only if there is indeed a change in the collection of the returned group names.
Otherwise, on every fetch, we'll be re-rendering the UI for nothing if nothing really has changed in the context of the health groups.