Skip to content

fix(#5108): show correct metadata details#5109

Merged
andreasfritz merged 5 commits intomasterfrom
fix/5108-broken-metadata-details
Feb 27, 2026
Merged

fix(#5108): show correct metadata details#5109
andreasfritz merged 5 commits intomasterfrom
fix/5108-broken-metadata-details

Conversation

@SteKoe
Copy link
Contributor

@SteKoe SteKoe commented Feb 24, 2026

This pull request focuses on improving the handling and display of instance metadata in the Spring Boot Admin UI (fixing #5108). It also adds tests for the metadata display component. The most important changes are grouped below:

Metadata Handling and Display

  • Fixed a logic error in details-metadata.vue so that the metadata table is displayed only when metadata is present, and improved the computed check for empty metadata to use the processed value. [1] [2]
  • Updated the Registration type in instance.ts so that metadata is now a dictionary of key-value pairs instead of an array, reflecting its actual usage throughout the codebase.

Testing

  • Added a new test suite details-metadata.spec.ts that verifies correct rendering of metadata, count display, empty state handling, and alphabetical sorting of metadata keys in the metadata details component.

Accordion Component Refactor

  • Refactored the sba-accordion.vue component to remove the internal _open state in favor of directly using the open prop, simplifying state management and ensuring consistent behavior with local storage and UI updates. [1] [2] [3] [4]

@SteKoe SteKoe requested a review from a team as a code owner February 24, 2026 13:35
@SteKoe SteKoe changed the title fix(#5108): show correct metadata details panel fix(#5108): show correct metadata details Feb 24, 2026
@andreasfritz andreasfritz merged commit f065224 into master Feb 27, 2026
2 checks passed
@andreasfritz andreasfritz deleted the fix/5108-broken-metadata-details branch February 27, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants