Repository navigation
flow-schema-extraction entrypoint drops schemas of inline sub-flows - #190
Merged
Merged
Conversation
InlineReferenceValue carries an optional database_id as of this version (code0-tech/tucana#377), which the schema extraction needs to address an individual inline reference.
getFlowSchemas enriches sub-flows sitting as an InlineReferenceValue inside a literal's references since #188, but flow-schema-extraction only reported parameters whose value is a SubFlowValue, so those schemas were discarded before serialization. The entrypoint now descends into a literal parameter's references, nested literals included, and reports every sub-flow it finds under a new subflowReferences key, addressed by the id of the inline reference holding it. The mapper maps that id from the proto's database_id. Since database_id is optional, a reference without one is left out rather than reported with a null id, which would make the consumer match the wrong rows. Closes #189
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #189