Patch lib extname to .so for apple-darwin#32
Conversation
8956623 to
29073d2
Compare
|
Is there a dependency we can add to the fixture project that fails without this change? |
|
Explorer was what was failing for me, but at runtime. That package is already included in the test suite so it seems we may need to include some sort of runtime test in the suite (if not already there). I'll play around with it a bit to see if I can come up with a failure case... |
29073d2 to
016a9a2
Compare
|
@camelpunch ok this should be ready for another look. I added a run-time case which runs "mix test" and that attemps to run Explorer (which fails until the patch is applied). |
There was a problem hiding this comment.
I don't really understand how to get your force-push rerun in GitHub Actions, but it looks to me like it's running a SHA that isn't on your current branch. Or I'm just confused. Either way, would you mind looking at the comments?
Happy to help with the Linux part if you don't have access to a Linux machine.
EDIT I was just confused, and was looking at the SHA after a merge into main. Weirdly, when I (or GitHub) merge your branch, the check gets past the error I posted. I'd still like to preserve the ability to build arbitrary mix deps from nix, though.
016a9a2 to
d603d09
Compare
|
Hi @camelpunch - thanks for the suggestion. I made the edit, let me know if that's what you had in mind. I also rebased the branch to main out of concern about the failing build above - I noticed it was a bit behind now. |
|
Thanks ❤️ |
Closes #31
On apple-darwin, libraries are compiled as
*.dylib, though Rustler expects a*.soextname. This patch updates the library name symlinked inpreConfigureto match what Rustler expects when loading the file at runtime.