Merged
Conversation
stephenliang
approved these changes
Mar 5, 2026
.babelrc
Outdated
Comment on lines
+3
to
+6
| "plugins": [ | ||
| "@babel/plugin-transform-object-rest-spread", | ||
| "@babel/plugin-transform-class-properties", | ||
| ["@babel/plugin-transform-regenerator", {"async": true, "asyncGenerators": true}] |
Member
There was a problem hiding this comment.
I actually wonder if these can be removed and just rely on the presets. Most of these are no longer needed in our official supported set and even our extended supported set of browsers.
Member
Author
There was a problem hiding this comment.
Good call. It looks to work without them.
breville
commented
Mar 7, 2026
| "@fortawesome/free-solid-svg-icons": "^5.11.2", | ||
| "@fortawesome/react-fontawesome": "^0.1.7", | ||
| "messageformat": "^1.1.0", | ||
| "messageformat": "2.3.0", |
Member
Author
There was a problem hiding this comment.
This fixes the following error when running yarn in the main repo with a symlinked ml-activities:
Cannot link @code-dot-org/ml-activities into blockly-mooc@workspace:. dependency messageformat@npm:1.1.1 conflicts with parent dependency messageformat@npm:2.3.0
breville
commented
Mar 7, 2026
src/oceans/assetPath.js
Outdated
Comment on lines
+5
to
+14
| // Sync webpack's internal public path (__webpack_require__.p) with the global. | ||
| // This is needed when this bundle is nested inside another webpack bundle (e.g. | ||
| // code-dot-org apps): webpack's automatic script-tag URL detection runs first | ||
| // and sets __webpack_require__.p to the host bundle's path. By overriding it | ||
| // here — before source files evaluate their module-level asset requires — | ||
| // asset/resource URLs (sounds, model.json) resolve to the correct location. | ||
| // Fall back to '/' for running locally. | ||
|
|
||
| /* eslint-disable-next-line no-undef */ | ||
| __webpack_public_path__ = global.__webpack_public_path__ || '/'; |
Member
Author
There was a problem hiding this comment.
Kudos to Claude Code for figuring this out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrades webpack from 4 to 5, bringing this repo (AI for Oceans) in line with our main repo.
Amongst other changes, it converts the use of a couple loaders (
url-loaderandfile-loader) to Asset Modules, as recommended by https://webpack.js.org/migrate/5/.It makes some minor updates to linting and tests to at least keep them passing.