Skip to content

Fix leaderboard ordering by date #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Didayolo wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix leaderboard ordering by date #2221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/static/riot/competitions/detail/leaderboards.tag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,11 @@
</td>
<td if="{submission.organization === null}"><a href="{submission.slug_url}">{ submission.owner }</a></td>
<td if="{submission.organization !== null}"><a href="{submission.organization.url}">{ submission.organization.name }</a></td>
<td>{ pretty_date(submission.created_when) }</td>
<td data-sort="{ sort_date_value(submission.created_when) }"
data-sort-value="{ sort_date_value(submission.created_when) }"
>
{ pretty_date(submission.created_when) }
</td>
<td>{submission.id}</td>
<td each="{ column in filtered_columns }">
<a if="{column.title == 'Detailed Results'}" href="detailed_results/{get_detailed_result_submisison_id(column, submission)}" target="_blank" class="eye-icon-link">
Expand Down Expand Up @@ -88,6 +92,12 @@
return ''
}
}

self.sort_date_value = function (date_string) {
if (!date_string) return 0
const dt = luxon.DateTime.fromISO(date_string)
return dt.isValid ? dt.toMillis() : 0
}

self.bold_class = function(column, submission){
// Return `text-bold` if submission has
Expand Down