Skip to content

HTTP(S) and Network mode options in Compute worker#2137

Merged
Didayolo merged 6 commits intodevelopfrom
competition_containers_restriction
Feb 25, 2026
Merged

HTTP(S) and Network mode options in Compute worker#2137
Didayolo merged 6 commits intodevelopfrom
competition_containers_restriction

Conversation

@ObadaS
Copy link
Collaborator

@ObadaS ObadaS commented Feb 3, 2026

A brief description of the purpose of the changes contained in this PR.

Added 3 new env variables to control the HTTP(S) proxy and whether to enable network access to the competition container

COMPETITION_CONTAINER_NETWORK_DISABLED=False


COMPETITION_CONTAINER_HTTP_PROXY=https://example_proxy:123
COMPETITION_CONTAINER_HTTPS_PROXY=http://example_proxy:1233

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ObadaS ObadaS force-pushed the competition_containers_restriction branch from 0c5a3ef to 693175b Compare February 5, 2026 08:16
@ObadaS ObadaS marked this pull request as ready for review February 9, 2026 08:15
@ObadaS ObadaS force-pushed the competition_containers_restriction branch from 693175b to b2391c7 Compare February 16, 2026 13:59
@Didayolo
Copy link
Member

Please add documentation about this

@ObadaS ObadaS marked this pull request as draft February 17, 2026 14:07
@ObadaS ObadaS force-pushed the competition_containers_restriction branch from b2391c7 to 61ca48e Compare February 17, 2026 15:11
@ObadaS ObadaS marked this pull request as ready for review February 17, 2026 15:11
@ObadaS ObadaS requested a review from Didayolo February 17, 2026 15:11
@Didayolo Didayolo self-assigned this Feb 17, 2026
@ObadaS ObadaS force-pushed the competition_containers_restriction branch from 61ca48e to 140cade Compare February 18, 2026 13:18
@Didayolo
Copy link
Member

Do you have a good suggestion on how to test this? Simply a scoring program that tries to download something?

@ObadaS
Copy link
Collaborator Author

ObadaS commented Feb 18, 2026

Do you have a good suggestion on how to test this? Simply a scoring program that tries to download something?

Yes, this is a good way to test the first new option (disable network)

For the Proxy options, you will need to use a VM that is behind a proxy, like our local GPU servers

@Didayolo Didayolo force-pushed the competition_containers_restriction branch from 140cade to 3f80688 Compare February 25, 2026 10:05
@Didayolo
Copy link
Member

Optional addition: made the ColumnFactory more robust.

At first try the CircleCI test did not pass, but I think it just happened randomly (the same key appeared twice) and is not related to this PR.

@Didayolo
Copy link
Member

All good to me. We need to test the Proxy part of the PR on the staging server

@Didayolo Didayolo merged commit c66c571 into develop Feb 25, 2026
2 checks passed
@Didayolo Didayolo deleted the competition_containers_restriction branch February 25, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants