fix(cocoonset): probe snapshot tags before delete - #32
Open
czmDeRepository wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CocoonSet teardown calls
DeleteManifestfor:hibernateand policy-selected:latesttags even when those manifests were never pushed. Although the client treats a 404 as success, some OCI registries materialize an empty repository while authorizing the DELETE request, leaving repository entries with no tags.This is common for
snapshotPolicy: never: neither teardown snapshot exists, but deleting the CocoonSet still sends registry DELETE requests.Fix
Registry.HasManifestAPI.DeleteManifestonly when the tag exists.:latesttags underneverand non-main roles undermain-only.The HEAD/DELETE race remains safe because
DeleteManifestalready treats a missing manifest as success.Validation
make fmt-checkmake testmake lintsnapshotPolicy: neversets no longer created empty repository records.