This repository was archived by the owner on Mar 5, 2023. It is now read-only.
Support for re-type the shortcut in MACShortcutView#115
Open
dstd wants to merge 1 commit intococoabits:masterfrom
Open
Support for re-type the shortcut in MACShortcutView#115dstd wants to merge 1 commit intococoabits:masterfrom
dstd wants to merge 1 commit intococoabits:masterfrom
Conversation
…ld will be temporarily deactivated to allow the user to type the same shortcut
|
@dstd it seems that owner of this repository would be fine with merging this if there wouldn't be conflicts. Do you think you could take a look at this? |
|
I can't tell what the merge conflict is. I can't see it in the web ui, and when I clone locally, merging Here's the diff from the merge, that successfully completed automatically: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When MASShortcutView starts the recording, a shortcut it currently holding will be temporarily deactivated to allow the user to type the same shortcut.