ci: add merge guard workflow for fixup commits and do-not-merge label#53
Merged
shubhamdhama merged 1 commit intocockroachdb:mainfrom Apr 13, 2026
Merged
Conversation
suj-krishnan
reviewed
Apr 7, 2026
suj-krishnan
left a comment
suj-krishnan
left a comment
There was a problem hiding this comment.
LGTM, except for the nit/query. Also, please add a one-line description. Thank you!
| - name: Check for fixup or squash commits | ||
| run: | | ||
| git fetch origin ${{ github.base_ref }} | ||
| COMMITS=$(git log --oneline "origin/${{ github.base_ref }}..HEAD" --grep="^fixup!" --grep="^squash!" --format="%h %s") |
There was a problem hiding this comment.
nit: do we need to check for 'squash!' in the commit message? (I don't see it being used). We can skip if it is not the convention.
Author
There was a problem hiding this comment.
I think it's fine to keep a squash! check too.
This guard will add a layer of protection against accidental merge of fixup commits.
shubhamdhama
force-pushed
the
disallow-merge
branch
from
4fc792e to
5abf708
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.