Open
Conversation
Fixes GHSA-wx95-c6cv-8532: nokogiri did not check the return value from xmlC14NExecute, allowing silent canonicalization failures that could enable SAML signature validation bypass in downstream libraries. Upgrade to 1.19.1 resolves this.
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
Files changed:
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
mohini-crl
requested changes
Feb 26, 2026
|
|
||
| BUNDLED WITH | ||
| 4.0.6 | ||
| 2.7.2 |
Contributor
There was a problem hiding this comment.
The lockfile’s BUNDLED WITH was changed from 4.0.6 → 2.7.2. Was that intentional? If not, can you regenerate the Gemfile.lock using the repo’s canonical Bundler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nokogirifrom1.19.0to1.19.1across all platform variants insrc/current/Gemfile.lockNokogiri::XML::Document#canonicalizeandNokogiri::XML::Node#canonicalizefailed to check the return value ofxmlC14NExecute, silently returning an empty string on failure instead of raising an exception. This was demonstrated to enable SAML signature validation bypass in downstream libraries.Closes https://github.com/cockroachdb/docs/security/dependabot/13
Test plan