Skip to content

Conversation

@fqazi
Copy link
Collaborator

@fqazi fqazi commented Dec 24, 2025

Previously, our last resort logic to read descriptors at the end timestamp for historical descriptors would behave incorrectly for locked descriptor leasing. This would read at the leased timestamp and, for initially created descriptors, incorrectly return "descriptor not found". Even if the descriptor is avaialble at the actual timestamp for the transaction. To address this, this patch surfaces these errors only if the base timestamp is not able to satisfy the request either. The findForTimestamp logic already attempts the base timestamp if the locked timestamp is not viable.

Fixes: #159998

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@fqazi fqazi force-pushed the handleHistoricReadsAtBase branch from 6e9224c to 7face00 Compare December 24, 2025 20:22
@fqazi fqazi marked this pull request as ready for review December 29, 2025 14:48
@fqazi fqazi requested a review from a team as a code owner December 29, 2025 14:48
@github-actions
Copy link

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

  • If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
  • If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

@github-actions github-actions bot added the o-AI-Review-Potential-Issue-Detected AI reviewer found potential issue. Never assign manually—auto-applied by GH action only. label Dec 29, 2025
@fqazi fqazi added O-AI-Review-Not-Helpful AI reviewer produced result which was incorrect or unhelpful O-AI-Review-Real-Issue-Found AI reviewer found real issue and removed O-AI-Review-Not-Helpful AI reviewer produced result which was incorrect or unhelpful labels Dec 29, 2025
@fqazi fqazi force-pushed the handleHistoricReadsAtBase branch from 7face00 to 1a892e2 Compare December 29, 2025 15:07
@github-actions
Copy link

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

  • If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
  • If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

@fqazi fqazi force-pushed the handleHistoricReadsAtBase branch from 1a892e2 to 07300aa Compare December 29, 2025 15:53
@github-actions
Copy link

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

  • If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
  • If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

Previously, our last resort logic to read descriptors at the end
timestamp for historical descriptors would behave incorrectly for locked
descriptor leasing. This would read at the leased timestamp and, for
initially created descriptors, incorrectly return "descriptor not
found". Even if the descriptor is avaialble at the actual timestamp for
the transaction. To address this, this patch surfaces these errors only
if the base timestamp is not able to satisfy the request either. The
findForTimestamp logic already attempts the base timestamp if the locked
timestamp is not viable.

Fixes: cockroachdb#159998

Release note: None
@fqazi fqazi force-pushed the handleHistoricReadsAtBase branch from 07300aa to 1750959 Compare December 29, 2025 16:00
@fqazi fqazi added O-AI-Review-Not-Helpful AI reviewer produced result which was incorrect or unhelpful and removed o-AI-Review-Potential-Issue-Detected AI reviewer found potential issue. Never assign manually—auto-applied by GH action only. labels Dec 29, 2025
@fqazi fqazi added the backport-26.1.x Flags PRs that need to be backported to 26.1 label Dec 29, 2025
@fqazi
Copy link
Collaborator Author

fqazi commented Dec 29, 2025

@rafiss TFTR!

bors r+

@rafiss rafiss added the o-AI-Review-Potential-Issue-Detected AI reviewer found potential issue. Never assign manually—auto-applied by GH action only. label Dec 29, 2025
@craig
Copy link
Contributor

craig bot commented Dec 29, 2025

@craig craig bot merged commit ee56624 into cockroachdb:master Dec 29, 2025
25 checks passed
@blathers-crl
Copy link

blathers-crl bot commented Dec 29, 2025

Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches.


Issue #159998: branch-release-26.1.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-26.1.x Flags PRs that need to be backported to 26.1 O-AI-Review-Not-Helpful AI reviewer produced result which was incorrect or unhelpful o-AI-Review-Potential-Issue-Detected AI reviewer found potential issue. Never assign manually—auto-applied by GH action only. O-AI-Review-Real-Issue-Found AI reviewer found real issue target-release-26.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

crosscluster/logical: TestRandomStream failed

3 participants