Conversation
## Summary - The `MaxSlots` guard in `reservation_manager.go` only counted blind-scheduler slots for the remaining delta, ignoring slots created by PAYG pre-allocation and already-existing slots - This allowed total slot count (existing + PAYG + blind-scheduler) to exceed `MaxSlotsPerCommitment` — e.g. MaxSlots=5, PAYG creates 4, blind-scheduler needs 3, check sees 3 ≤ 5 and passes → 7 total - Fixed by comparing `len(existing) + result.Created + newSlots` against MaxSlots before entering Phase 5 ## Test plan - [x] Added `TestApplyCommitmentState_MaxSlotsWithPAYG` with 3 cases covering the bypass scenario - [x] Updated existing MaxSlots test to validate existing slots now count toward the limit - [x] `make test` passes - [x] `make lint` passes 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: cortex-ai-agents[bot] <279748396+cortex-ai-agents[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com> Co-authored-by: mblos <mblos@users.noreply.github.com> Co-authored-by: mblos <156897072+mblos@users.noreply.github.com>
…in name enforcement 400s (#999) - After Limes rolled out domain name enforcement (sapcc/limes#909), requests with a non-matching `Host` header are rejected with HTTP 400 - Fixed by hardcoding `public` availability for the Limes endpoint lookup in `limes_api.go`, consistent with what the commitment syncer already does
bump app version [skip ci] ``` bumped cortex: sha-124ec226 -> sha-c4a7a1f2 noop cortex-shim (sha-124ec226) noop cortex-postgres (sha-af707446) ``` Co-authored-by: mblos <156897072+mblos@users.noreply.github.com>
bump app version [skip ci] ``` bumped cortex: sha-c4a7a1f2 -> sha-44b8aab7 bumped cortex-shim: sha-124ec226 -> sha-44b8aab7 noop cortex-postgres (sha-af707446) ``` Co-authored-by: mblos <156897072+mblos@users.noreply.github.com>
mblos
requested review from
PhilippMatthes,
SoWieMarkus,
auhlig,
juliusclausnitzer and
umswmayj
as code owners
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
|
@claude run the /release 1001 command |
Contributor
|
Claude finished @mblos's task in 13m 40s —— View job Release Orchestrator — PR #1001 Complete ✅
Release #1001 Post-Open Summary
Bumped versions:
|
This was referenced Jul 1, 2026
Bump helm chart versions for release PR #1001. Bumped: cortex 0.2.0→0.2.1, cortex-postgres 0.6.6→0.6.7, cortex-shim 0.1.3→0.1.4, bundles 0.0.77→0.0.78, cortex-placement-shim 0.1.3→0.1.4. This PR must be merged before #1001. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: cortex-ai-agents[bot] <279748396+cortex-ai-agents[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Add changelog entry for release PR #1001. Merge after #1001. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: cortex-ai-agents[bot] <279748396+cortex-ai-agents[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
Test Coverage ReportTest Coverage 📊: 69.9% |
umswmayj
approved these changes
Jul 1, 2026
SoWieMarkus
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
cortex v0.2.1 (sha-44b8aab7)
Non-breaking changes:
MaxSlotsPerCommitment(#987)Hostheaders (#999)cortex-shim v0.1.4 (sha-44b8aab7)
Includes updated image sha-44b8aab7.
cortex-nova v0.0.78
Includes updated charts cortex v0.2.1, cortex-postgres v0.6.7.
cortex-cinder v0.0.78
Includes updated charts cortex v0.2.1, cortex-postgres v0.6.7.
cortex-manila v0.0.78
Includes updated charts cortex v0.2.1, cortex-postgres v0.6.7.
cortex-crds v0.0.78
Includes updated chart cortex v0.2.1.
cortex-ironcore v0.0.78
Includes updated chart cortex v0.2.1.
cortex-pods v0.0.78
Includes updated chart cortex v0.2.1.
cortex-placement-shim v0.1.4
Includes updated chart cortex-shim v0.1.4.
Dependencies