Repository navigation
test: fix broken typecheck script and add regression test - #405
Open
hivecommons-hive[bot] wants to merge 1 commit into
Open
hivecommons-hive[bot] wants to merge 1 commit into
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
tsconfig.json extends @docusaurus/tsconfig, which still sets baseUrl. typescript ~7.0.2 removed that option entirely (TS5102), so npm run typecheck has been failing immediately with zero signal anywhere. Override the inherited baseUrl to null in our own compilerOptions to strip it from the merged config tsc evaluates. Add scripts/typecheck.test.mjs, which shells out to npx tsc --noEmit and asserts a zero exit code, so this is covered by the existing scripts/**/*.test.mjs glob in test:unit with no CI workflow change needed. Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Agent PRs are held at ACMM L3–L5; an Hive will keep the |
✅ Deploy Preview for cncf-techdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
npm run typecheck(tsc) has been failing immediately with:tsconfig.jsonextends@docusaurus/tsconfig, which still setsbaseUrl: "."; this repo's devDependencytypescriptis pinned to~7.0.2, which removed that option outright, so the inherited valuehard-errors. The script was never invoked anywhere (local or CI), so this
had zero signal.
This PR overrides the inherited
baseUrltonullin our owncompilerOptions(TS mergesextendsconfigs, andnullstrips theinherited key), which makes
npm run typecheckexit 0 cleanly again. Italso adds
scripts/typecheck.test.mjs, a regression test that shells outto
npx tsc --noEmitand asserts a zero exit code — verified to failagainst the pre-fix
tsconfig.jsonand pass against the fix. It's pickedup automatically by the existing
scripts/**/*.test.mjsglob intest:unit, so no.github/workflows/change is needed for this part.npm run test:coveragestill reports 100% stmts/branch/funcs/lines acrossall included files.
Related Issue
Part of #390 (the hive consolidated a new issue for this finding into the
existing #390 tracker as the same format-check.yml-related component; this
PR only fixes the local typecheck-script bug and adds a regression test —
wiring
npm run typecheckinto actual CI still needs a.github/workflows/change this lane's contributor-tier token cannotpush, same as the rest of #390)
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-opus-4-6 copilot=1.0.88