Skip to content

Add a default constructor to llvm::SuccIterator (gcc15) #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akritkbehera merged 1 commit into from
Sep 3, 2026
Merged

Add a default constructor to llvm::SuccIterator (gcc15) #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions third_party/xla/third_party/llvm/gcc15.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,20 @@ index 4a492ee2f..a7ede4bf7 100644
for (auto *Sym : Externals) {
SectionRangeSymbolDesc D = F(G, *Sym);

diff --git a/llvm/include/llvm/IR/CFG.h b/llvm/include/llvm/IR/CFG.h
--- a/llvm/include/llvm/IR/CFG.h
+++ b/llvm/include/llvm/IR/CFG.h
@@ -180,7 +180,12 @@ class SuccIterator
};

public:
- // begin iterator
+ // default constructed (singular) iterator. libstdc++ 15 gives
+ // std::reverse_iterator's default constructor the exception specification
+ // noexcept(noexcept(Iterator())), which C++20's default_initializable check
+ // instantiates -- a hard error, not a SFINAE failure, without this.
+ SuccIterator() : Inst(nullptr), Idx(0) {}
+ // begin iterator
explicit inline SuccIterator(InstructionT *Inst) : Inst(Inst), Idx(0) {}
// end iterator
inline SuccIterator(InstructionT *Inst, bool) : Inst(Inst) {
Loading