Skip to content

Add browser-based tests for CWS - #1740

Open
pxsit wants to merge 3 commits into
cms-dev:mainfrom
pxsit:browser-based-test
Open

pxsit wants to merge 3 commits into
cms-dev:mainfrom
pxsit:browser-based-test

Conversation

@pxsit

@pxsit pxsit commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Refs #1466

  • Playwright tests in cmstestsuite/browser_tests/ run a real ContestWebServer on a seeded database and check the contestant pages and their JavaScript. Run with docker/cms-browser-test.sh.
  • Small template fixes: aria-label="Close" on the close buttons, and an escaped - in the username pattern in register.html (current Chromium rejects the old one).

Copilot AI balanced review requested due to automatic review settings November 9, 2026 15:35

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@codecov

codecov Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 526 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.81%. Comparing base (bcf7a88) to head (f6dcd84).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
cmstestsuite/browser_tests/seed.py 0.00% 106 Missing ⚠️
cmstestsuite/browser_tests/conftest.py 0.00% 76 Missing ⚠️
cmstestsuite/browser_tests/submissions_test.py 0.00% 66 Missing ⚠️
cmstestsuite/browser_tests/testing_test.py 0.00% 61 Missing ⚠️
cmstestsuite/browser_tests/registration_test.py 0.00% 60 Missing ⚠️
cmstestsuite/browser_tests/navigation_test.py 0.00% 44 Missing ⚠️
cmstestsuite/browser_tests/login_test.py 0.00% 35 Missing ⚠️
cmstestsuite/browser_tests/downloads_test.py 0.00% 31 Missing ⚠️
cmstestsuite/browser_tests/communication_test.py 0.00% 23 Missing ⚠️
cmstestsuite/browser_tests/notifications_test.py 0.00% 12 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1740      +/-   ##
==========================================
- Coverage   56.84%   55.81%   -1.04%     
==========================================
  Files         344      355      +11     
  Lines       28360    28886     +526     
==========================================
+ Hits        16121    16122       +1     
- Misses      12239    12764     +525     
Flag Coverage Δ
functionaltests 0.00% <ø> (ø)
unittests 55.81% <0.00%> (-1.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants