This repository was archived by the owner on Feb 28, 2022. It is now read-only.
Url handling possible fixes#2
Open
mcrmfc wants to merge 2 commits intoclowder:masterfrom
mcrmfc:url_handling_possible_fixes
Open
Url handling possible fixes#2mcrmfc wants to merge 2 commits intoclowder:masterfrom mcrmfc:url_handling_possible_fixes
mcrmfc wants to merge 2 commits intoclowder:masterfrom
mcrmfc:url_handling_possible_fixes
Conversation
added 2 commits
November 22, 2011 17:18
…ession it should behave like click_link#click_link should follow relative links
…form with a relative action - where mechanize needs the full URL not just the action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrt the changes to form.rb I started looking at this when I was testing a simple Google search - which is a GET on a form submission, mechwarrior was handing just the form action to Mechanize which was failing as it required a full URL.
The second change to node.rb fixes a failing spec in Capybara with a relative href on a link.
I know both these changes smell a bit, so 100% understand if you don't want to merge them...maybe just a start of a conversation about how best these scenarios should be handled?