chore: Fix style specificity issue in custom style flashbar#4684
Draft
at-susie wants to merge 2 commits into
Draft
chore: Fix style specificity issue in custom style flashbar#4684at-susie wants to merge 2 commits into
at-susie wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4684 +/- ##
=======================================
Coverage 97.57% 97.57%
=======================================
Files 948 948
Lines 30496 30502 +6
Branches 11155 11160 +5
=======================================
+ Hits 29756 29762 +6
+ Misses 733 693 -40
- Partials 7 47 +40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…mponents Revert flashbar-icon button variant to use colorTextInteractiveInverted* tokens instead of colorTextInteractive*. The previous approach overrode colorTextInteractiveDefault in flashbar contexts, which broke board-components (and any other package using that token inside a flashbar). The fix uses colorTextInteractiveInvertedDefault/Hover in contexts where the dismiss button needs different colors: - VR/classic flashbar: inherits global inverted values (light on dark) - VR flashbar-warning: overrides inverted to dark values (dark on light) - One-theme flashbar/warning: overrides inverted to dark values (dark on light)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the specificity issue that we found in the regression in a screenshot test in the pages/flashbar/style-custom.page.tsx page, which was introduced in #4671
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.