-
Notifications
You must be signed in to change notification settings - Fork 231
chore: Generate test definitions #4544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jperals
wants to merge
1
commit into
main
Choose a base branch
from
chore/test-definitions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| const execa = require('execa'); | ||
| const { task } = require('../utils/gulp-utils'); | ||
|
|
||
| module.exports = task('test-definitions', () => | ||
| execa('tsc', ['-p', 'tsconfig.test-definitions.json'], { stdio: 'inherit' }) | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| // Each component has its own test definition file. | ||
| // Import them here manually to form the full test suite. | ||
| import { TestSuite } from './types'; | ||
| import actionCard from './visual/action-card'; | ||
| import alert from './visual/alert'; | ||
|
|
||
| export const allSuites: TestSuite[] = [actionCard, alert]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| import type { ScreenshotPageObject } from '@cloudscape-design/browser-test-tools/page-objects'; | ||
|
|
||
| export interface ScreenshotTestConfiguration { | ||
| width?: number; | ||
| height?: number; | ||
| } | ||
|
|
||
| // 'screenshotArea' — captures the .screenshot-area element on the page. | ||
| // 'permutations' — captures the entire page and crops permutations out of it. | ||
| export type ScreenshotType = 'screenshotArea' | 'permutations'; | ||
|
|
||
| export interface TestDefinition { | ||
| description: string; | ||
| path: string; | ||
| screenshotType: ScreenshotType; | ||
| queryParams?: Record<string, string>; | ||
| configuration?: ScreenshotTestConfiguration; | ||
| setup?: (page: ScreenshotPageObject) => Promise<void>; | ||
| } | ||
|
|
||
| export interface TestSuite { | ||
| componentName?: string; | ||
| description: string; | ||
| tests: Array<TestDefinition | TestSuite>; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| import { TestSuite } from '../types'; | ||
|
|
||
| const suite: TestSuite = { | ||
| description: 'Action card', | ||
| componentName: 'action-card', | ||
| tests: [ | ||
| { | ||
| description: 'permutations', | ||
| path: 'action-card/permutations', | ||
| screenshotType: 'permutations', | ||
| }, | ||
| { | ||
| description: 'variant permutations', | ||
| path: 'action-card/variant-permutations', | ||
| screenshotType: 'permutations', | ||
| }, | ||
| { | ||
| description: 'padding permutations', | ||
| path: 'action-card/padding-permutations', | ||
| screenshotType: 'permutations', | ||
| }, | ||
| { | ||
| description: 'simple', | ||
| path: 'action-card/simple', | ||
| screenshotType: 'screenshotArea', | ||
| }, | ||
| ], | ||
| }; | ||
|
|
||
| export default suite; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| import { TestSuite } from '../types'; | ||
|
|
||
| const suite: TestSuite = { | ||
| description: 'Alert', | ||
| componentName: 'alert', | ||
| tests: [ | ||
| { | ||
| description: 'simple', | ||
| path: 'alert/simple', | ||
| screenshotType: 'screenshotArea', | ||
| }, | ||
| { | ||
| description: 'style custom page', | ||
| path: 'alert/style-custom-types', | ||
| screenshotType: 'screenshotArea', | ||
| }, | ||
| ...[600, 1280].map(width => ({ | ||
| description: `width ${width}px`, | ||
| tests: [ | ||
| { | ||
| description: 'permutations', | ||
| path: 'alert/permutations', | ||
| screenshotType: 'permutations' as const, | ||
| }, | ||
| { | ||
| description: 'custom types', | ||
| path: 'alert/style-custom-types', | ||
| screenshotType: 'screenshotArea' as const, | ||
| }, | ||
| ], | ||
| })), | ||
| ], | ||
| }; | ||
|
|
||
| export default suite; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| { | ||
| "compilerOptions": { | ||
| "lib": ["ES2021", "DOM"], | ||
| "target": "ES2019", | ||
| "types": [], | ||
| "module": "CommonJS", | ||
| "moduleResolution": "node", | ||
| "esModuleInterop": true, | ||
| "strict": true, | ||
| "declaration": true, | ||
| "declarationMap": true, | ||
| "sourceMap": true, | ||
| "inlineSources": true, | ||
| "rootDir": "test/definitions", | ||
| "outDir": "lib/test-definitions", | ||
| "skipLibCheck": true | ||
| }, | ||
| "include": ["test/definitions", "test/types.ts"], | ||
| "exclude": [] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two files are inside
test/definitions/visualbecause they are definitions of visual regression tests, but I intentionally named the build files and process after just "test definitions" and not specifically "visual test definitions" because this approach can be used for other tests, such as integration tests, if we later want to.