fix: Declare micromatch as a dependency - #84
Open
TrevorBurnham wants to merge 1 commit into
Open
Conversation
Three ESLint rules import micromatch, which was declared nowhere in the manifest: it resolved only by hoisting from fast-glob and lint-staged, both devDependencies, so a consumer's tree can be missing it entirely. minimatch was declared in its place and is imported by nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three ESLint rules import
micromatch(ban-files,no-internal-in-public-interfaces,react-server-components-directive), and it was declared nowhere in the manifest. It resolves today only by hoisting fromfast-globandlint-staged, both devDependencies, so a consumer whose own tree lacks those gets a module-not-found at lint time.minimatchwas declared in its place and is imported by nothing.Effect on consumers
@cloudscape-design/build-toolsis not published to npm. All 10 consuming repos declare it asgithub:cloudscape-design/build-tools#mainand none of their committed lockfiles contain a@cloudscape-design/*entry, so merging reaches every consumer on its next install. Declaring a dependency they already resolve transitively cannot break them, and no consumer declares or importsminimatch.Lockfile
One insertion, 43 deletions: the orphaned
node_modules/minimatchentry with its nestedbalanced-matchandbrace-expansion, plus six staledevOptional: trueflags that still describedmicromatchas dev-only. Produced with npm 10 deliberately, since npm 11 rewrites a further ~960 unrelated lines by pruning an optional-peer subtree.Split out of #77, which is otherwise unrelated to it.