Repository navigation
fix: Correct scalar validity for null timestamps and empty lists - #423
Draft
Kayvan-Zahiri wants to merge 1 commit into
Draft
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scalar validity depends on assignment history in two cases. After a valid timestamp,
Timestamp.set(None)leaves the scalar valid and still prints the timestamp. Conversely, assigning an empty list or tuple to a fresh List leaves it invalid and printsnull; it prints[]when a nonempty list was assigned first.Invalidate Timestamp on None, matching numeric and date scalar behavior. Mark a successfully constructed List vector valid after its elements have been processed, including when there are no elements. Eight public-API regression cases cover accepted timestamp input types, null resets and reuse, empty list/tuple inputs, and both fresh and previously populated lists.
These changes concern the validity flag and string representation. They preserve the SDK's existing stored-value behavior and do not change Arrow serialization or the behavior of other scalar types.
Validation using the unchanged uv.lock and Python 3.14.0 (matching CI's Python minor version):
Earlier focused tests on Python 3.12 also passed all 41 scalar cases. No live cloud services or customer data were used.