fix(template): standalone mode should skip externalClusters#760
Open
ArnaudTA wants to merge 1 commit intocloudnative-pg:mainfrom
Open
fix(template): standalone mode should skip externalClusters#760ArnaudTA wants to merge 1 commit intocloudnative-pg:mainfrom
ArnaudTA wants to merge 1 commit intocloudnative-pg:mainfrom
Conversation
dosubot
bot
added
size:XS
ArnaudTA
force-pushed
the
fix/null-external-clusters
branch
from
c70eece to
5401c65
Compare
ankitml
added a commit
to paradedb/charts
that referenced
this pull request
Dec 29, 2025
Updated to match upstream PR cloudnative-pg#760 which fixes the same issue: - Moved externalClusters field inside conditional in template - Reverted cluster.yaml to unconditional include - Preserved ParadeDB-specific custom externalClusters feature This minimizes future rebase conflicts with upstream while maintaining backward compatibility with ParadeDB's custom external cluster configuration. Related: cloudnative-pg#760
ArnaudTA
force-pushed
the
fix/null-external-clusters
branch
from
66b3102 to
b36317e
Compare
Author
|
Up plz |
|
@itay-grudev Could we please get this merged and released? This would fix the |
Signed-off-by: ArnaudTa <33383276+ArnaudTA@users.noreply.github.com>
ArnaudTA
force-pushed
the
fix/null-external-clusters
branch
from
b36317e to
0b2f943
Compare
|
Hi CNPG community Is there any chance we could get Helm v4 support soon? Pretty please 👉👈 |
|
Is there a timeline on when this will be merged? Hoping to have #756 addressed. |
|
@itay-grudev This PR would unblock Helm 4 deployments and is relatively small in size. Is there a reason that this, but also other PRs, are rarely reviewed and merged lately by the chart maintainers? Is this due to time constraints or is the general idea to stop relying on the CNPG helm charts and rather use CNPG K8s resources directly for our deployments? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#753
#756