fix: --json output fails with a circular structure error - #10
Merged
Conversation
… shape The flattened response was normalized by inserting the account object into its own product_environments array, which made --json output fail with "Converting circular structure to JSON". Insert a copy instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
npx @cloudinary/cloud --jsonfails after a successful provision:When the API returns the flattened response shape (environment fields directly on the account object),
normalizeAccountrebuilt the nestedproduct_environmentscontract by inserting the account object into its own array. The human and plain output modes read individual fields and were unaffected, but--jsonstringifies the whole account and throws. The cloud is still provisioned when this happens, so the caller loses the credentials from their output.Fix
Insert a shallow copy of the environment fields (minus
product_environments) instead of a self-reference, keeping the account JSON-serializable.Testing
JSON.stringify.🤖 Generated with Claude Code