introduce @Value wiring for allowPublicClients in ClientAdminBootstrap

[robl-sap]

Problem

When ClientAdminBootstrap was converted to a @component (commit a1459a3), the @value SpEL annotation was accidentally dropped from the allowPublicClients constructor parameter. Without it, Spring performs type-based injection and injects all String-typed beans from the context into that Set instead of reading oauth.client.allowpublic from the YAML config.

Fix

Restore the @value expression on the allowPublicClients parameter with null-guards for the case where oauth or oauth.client are absent from the config:

@value("#{@config['oauth']==null ? null : @config['oauth']['client']==null ? null : @config['oauth']['client']['allowpublic']}")

Tests

Added ClientAdminBootstrapWiringTest — a minimal Spring context wiring test that covers three scenarios:

• oauth.client.allowpublic is configured → correct client ID is picked up
• oauth key is absent from config → resolves to empty set (no NPE)
• oauth.client subkey is absent → resolves to empty set (no NPE)

[Copilot]

Copilot review overview

🟢 Approval recommended

Only a documentation nit remains; no blocking issues were identified.

Review effort: Lite
Findings: None

What changed in this PR

Restores Spring configuration binding for oauth.client.allowpublic and adds regression coverage for missing nested configuration.

Changes:

• Restores null-safe @Value SpEL injection.
• Adds wiring tests for configured and absent YAML paths.

File	Summary
server/​src/​main/​java/​org/​cloudfoundry/​identity/​uaa/​client/​ClientAdminBootstrap.java	Restores configuration-based public client injection. Minor nit: document the property in the configuration reference.
server/​src/​test/​java/​org/​cloudfoundry/​identity/​uaa/​client/​ClientAdminBootstrapWiringTest.java	Verifies configured, missing oauth, and missing oauth.client scenarios.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[strehle]

please. check unit tests

[Copilot]

Copilot review overview

🟢 Approval recommended

The remaining accessor concern is a non-blocking nit; wiring, tests, and documentation are covered.

Review effort: Lite
Findings: 1

Open (1)

• Document restored oauth.client.allowpublic configuration property

Resolved since last review (2)

• Register placeholder configurer in all test configurations
• Document allowpublic configuration type as List<String>

[Copilot]

Copilot review overview

🟢 Approval recommended

The remaining findings are minor, non-blocking nits.

Review effort: Lite
Findings: 1

Open (1)

• Document restored oauth.client.allowpublic configuration property