Conversation
ZPascal
marked this pull request as draft
September 21, 2026 10:22
ZPascal
force-pushed
the
issue-98
branch
2 times, most recently
from
September 21, 2026 12:05
4fe1601 to
aee3d10
Compare
ZPascal
force-pushed
the
issue-98
branch
2 times, most recently
from
September 22, 2026 21:24
fdb8c5d to
c3cf45e
Compare
…tu Resolute
libicu-dev was dropped from the Ubuntu Resolute stemcell, breaking
postgres-16/17/18 compilation which requires ICU at build time.
- Add postgres-libicu BOSH package that compiles ICU4C 78.3 from a vendored
source tarball (static-only, --disable-shared) so postgres links ICU
statically with no runtime .so dependency
- Update postgres-15, -16, -17, -18 to support aarch64 in packaging scripts
- Update postgres-16, -17, -18 to declare postgres-libicu as a dependency
and use ${BOSH_PACKAGES_PATH:-/var/vcap/packages}/postgres-libicu in
configure flags with -lstdc++ to satisfy C++ runtime symbols from static ICU
Closes #98
Jobsby
reviewed
Sep 23, 2026
Jobsby
left a comment
Contributor
There was a problem hiding this comment.
Please check the ICU release version and name changes between 77 and 78.
| trigger: true | ||
| params: | ||
| globs: | ||
| - icu4c-*-src.tgz |
Contributor
There was a problem hiding this comment.
globs does not match ICU 78+ asset names
globs:
- icu4c-*-src.tgz
ICU also renamed their source tarball starting with version 78 (sources instead of src).
You can verify this directly on the GitHub releases page: https://github.com/unicode-org/icu/releases
- release-78.3 -> icu4c-78.3-sources.tgz -> does not match
- release-77-1 -> icu4c-77_1-src.tgz -> matches
That might become a problem.
| source: | ||
| owner: unicode-org | ||
| repository: icu | ||
| tag_filter: release-([0-9]+-[0-9]+) |
Contributor
There was a problem hiding this comment.
tag_filter does not match ICU 78+ tags (see comment above)
tag_filter: release-([0-9]+-[0-9]+)
ICU changed their tag format starting with version 78 (dot instead of dash separator):
- ICU ≤ 77: release-77-1 -> matches
- ICU ≥ 78: release-78.3 -> does not match
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
postgres-libicuBOSH package that compiles ICU4C from a vendored source tarball, removing the dependency onlibicu-devwhich was dropped from the Ubuntu Resolute stemcellpostgres-16,postgres-17, andpostgres-18to declarepostgres-libicuas a dependency and use${BOSH_PACKAGES_PATH}/postgres-libicuin their configure flags instead of hardcoded system pathsbump-libicu-packageCI task andicu-srcConcourse resource so ICU blob bumps are automated in thebump-packagespipeline jobpostgres-16/17/18: replaces ignored#!/bin/bash -exuwith#!/bin/bash+set -euo pipefailper BOSH conventionsCloses #98
Test Plan
bump-packagesCI job to verify thebump-libicu-packagetask runs without errorspostgres-16,postgres-17, andpostgres-18on a Resolute stemcell and verifyinitdb/pg_ctl startsucceedpostgres-15is unaffected (no ICU dependency, no packaging changes)libicui18n.sois not present in the package install target (only.astatic libs, due to--disable-shared)