Reuse installed ginkgo and use cleaner binary check#609
Open
jorbaum wants to merge 6 commits intocloudfoundry:mainfrom
Open
Reuse installed ginkgo and use cleaner binary check#609jorbaum wants to merge 6 commits intocloudfoundry:mainfrom
jorbaum wants to merge 6 commits intocloudfoundry:mainfrom
Conversation
cf-foundation-community-automation
bot
moved this to Inbox
in Application Runtime Platform Working Group
numOfRoutes is never negative anyway
ClientSecret is not exposed to outside.
URI address is not provided by user but by server-side config.
Security scan not necessary for non-production files
chombium
requested changes
Mar 2, 2026
Contributor
chombium
left a comment
chombium
left a comment
There was a problem hiding this comment.
Please change the linting directives
|
|
||
| func (c *CAPIClient) HasApp(sourceID, authToken string) bool { | ||
| req, err := http.NewRequest(http.MethodGet, c.addr+"/v3/apps/"+sourceID, nil) | ||
| req, err := http.NewRequest(http.MethodGet, c.addr+"/v3/apps/"+sourceID, nil) //#nosec G704 |
Contributor
There was a problem hiding this comment.
Please use //nolint:gosec instead of #nosec as we are using gosec via golang and not directly.
Contributor
Author
There was a problem hiding this comment.
Good point. There are several instances where there nosec is already used in this code base. Do you want me to change those as well?
jorbaum
commented
Mar 2, 2026
Contributor
Author
jorbaum
left a comment
jorbaum
left a comment
There was a problem hiding this comment.
Worked in the comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adjusts test scripts just like cloudfoundry/loggregator-agent-release#717 :
Type of change
Testing performed?
Checklist:
mainbranch, or relevant version branch