Skip to content

fix: log system manager additions at FINE - #17

Merged
stokpop merged 2 commits into
cloudfoundry:mainfrom
stokpop:chore/watcher-tests-and-logging
Oct 21, 2026
Merged

stokpop merged 2 commits into
cloudfoundry:mainfrom
stokpop:chore/watcher-tests-and-logging

Conversation

@stokpop

@stokpop stokpop commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Adding System Trust Manager / Adding System Key Manager were logged at INFO every time a factory was initialized, e.g. per new database connection or HTTP client; now FINE. Log messages built with String.format are now only formatted when their level is enabled. The trust manager watcher test now replaces the file atomically and fails within 30 seconds instead of 300.

FileWatchingX509ExtendedKeyManager is left out here to avoid conflicts with #16, which already logs lazily.

Closes #13

@kiril-keranov kiril-keranov left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Logged at INFO on every factory init, e.g. per new connection or
HTTP client. Format log messages lazily.

Closes cloudfoundry#13
@stokpop
stokpop force-pushed the chore/watcher-tests-and-logging branch from a6511de to dd7e6c3 Compare October 19, 2026 15:07
@stokpop
stokpop merged commit c90ae0c into cloudfoundry:main Oct 21, 2026
4 checks passed
@stokpop
stokpop deleted the chore/watcher-tests-and-logging branch October 21, 2026 06:53
stokpop added a commit to stokpop/java-buildpack-security-provider that referenced this pull request Nov 5, 2026
The summary was logged at INFO for every factory init, e.g. per new
connection, which brings back the noise fixed in cloudfoundry#17. Log it at INFO
for the first init in a JVM and at FINE afterwards.
stokpop added a commit to stokpop/java-buildpack-security-provider that referenced this pull request Nov 5, 2026
Log the number of trusted certificates for the system and container
trust managers, plus the system trust store source and the JDK blocklist
summary. The system summary is logged at INFO once per JVM and at FINE
afterwards, so it does not bring back the per-connection noise fixed in
cloudfoundry#17.
stokpop added a commit to stokpop/java-buildpack-security-provider that referenced this pull request Nov 5, 2026
Log the number of trusted certificates for the system and container
trust managers, plus the system trust store source and the JDK blocklist
summary. The system summary is logged at INFO once per JVM and at FINE
afterwards, so it does not bring back the per-connection noise fixed in
cloudfoundry#17.
stokpop added a commit to stokpop/java-buildpack-security-provider that referenced this pull request Nov 5, 2026
Log the number of trusted certificates for the system and container
trust managers, plus the system trust store source and the JDK blocklist
summary. The system summary is logged at INFO once per JVM and at FINE
afterwards, so it does not bring back the per-connection noise fixed in
cloudfoundry#17.
stokpop added a commit to stokpop/java-buildpack-security-provider that referenced this pull request Nov 5, 2026
Log the number of trusted certificates for the system and container
trust managers, plus the system trust store source and the JDK blocklist
summary. The system summary is logged at INFO once per JVM and at FINE
afterwards, so it does not bring back the per-connection noise fixed in
cloudfoundry#17.
stokpop added a commit to stokpop/java-buildpack-security-provider that referenced this pull request Nov 6, 2026
Log the number of trusted certificates for the system and container
trust managers, plus the system trust store source and the JDK blocklist
summary. The system summary is logged at INFO once per JVM and at FINE
afterwards, so it does not bring back the per-connection noise fixed in
cloudfoundry#17.
stokpop added a commit to stokpop/java-buildpack-security-provider that referenced this pull request Nov 6, 2026
Log the number of trusted certificates for the system and container
trust managers, plus the system trust store source and the JDK blocklist
summary. The system summary is logged at INFO once per JVM and at FINE
afterwards, so it does not bring back the per-connection noise fixed in
cloudfoundry#17.
stokpop added a commit to stokpop/java-buildpack-security-provider that referenced this pull request Nov 6, 2026
Log the number of trusted certificates for the system and container
trust managers, plus the system trust store source and the JDK blocklist
summary. The system summary is logged at INFO once per JVM and at FINE
afterwards, so it does not bring back the per-connection noise fixed in
cloudfoundry#17.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decrease logging of CloudFoundryContainerTrustManagerFactory

2 participants