Document more source types v2 - #610
Conversation
fa0559a to
b74ae11
Compare
I took a deeper look to double check and adjusted as per my findings
b74ae11 to
3c71eb1
Compare
| By changing the Java log output, you can force your app to reformat stack trace messages, replacing newline | ||
| characters with a token. Set your log parsing code to replace that token with newline characters again to display the | ||
| logs properly in Kibana. No newline at end of file | ||
| logs properly in Kibana. |
There was a problem hiding this comment.
please add back the new line at the end of the file.
There was a problem hiding this comment.
My changes actually added the newline so it follows normal POSIX style. However, I could revert if you like to keep changes more minimal.
|
@chombium thanks for the review. I worked in most of your comments. Marking it ready for review now even though I left the one comment about the newline unresolved. |
| ### <a id='health'></a> HEALTH | ||
|
|
||
| The Diego Cell emits `HEALTH` logs when running health check actions for an app. These logs are generated by the health check binary that monitors app instances. By default, health check log output is suppressed unless an error occurs. | ||
| The Diego Cell emits `HEALTH` logs for health check activity of an app. This inlcudes lifecycle events as well as monitoring start and health-state transitions. By default, most health check log output is suppressed. |
There was a problem hiding this comment.
on an app=> of an app
The last sentence in the paragraph By default, health check log output is suppressed unless an error occurs. which is deleted should be brought back in as it describes the default behavior
There was a problem hiding this comment.
Please add the rest of the sentence unless an error occurs. as well, as the output is written in case of errors.
| ### <a id='health'></a> HEALTH | ||
|
|
||
| The Diego Cell emits `HEALTH` logs when running health check actions for an app. These logs are generated by the health check binary that monitors app instances. By default, health check log output is suppressed unless an error occurs. | ||
| The Diego Cell emits `HEALTH` logs for health check activity of an app. This inlcudes lifecycle events as well as monitoring start and health-state transitions. By default, most health check log output is suppressed. |
There was a problem hiding this comment.
Please add the rest of the sentence unless an error occurs. as well, as the output is written in case of errors.
2 participants
Follow up of #577 / #609 .