Require authentication when changing broker URL origin - #5477
Open
WeiQuan0605 wants to merge 1 commit into
Open
WeiQuan0605 wants to merge 1 commit into
WeiQuan0605 wants to merge 1 commit into
Conversation
jochenehret
approved these changes
Sep 24, 2026
jochenehret
left a comment
Contributor
There was a problem hiding this comment.
Tested on a bbl env, works.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
Add a validation in ServiceBrokerUpdate#enqueue_update that rejects a URL-only PATCH request when the new URL has a different origin (scheme + host + port) from the current broker URL, unless authentication is also provided in the same request.
An explanation of the use cases your change solves
A SpaceDeveloper with access to a space-scoped broker could send PATCH /v3/service_brokers/:guid with only a new url pointing to an attacker-controlled server. Cloud Controller would preserve the old Basic credentials and send them to the new URL during the background catalog sync job, leaking the broker credentials to the attacker before any rollback could occur.
This fix prevents the credential exfiltration by requiring authentication to be re-supplied whenever the broker URL origin changes.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests