New Rake task to check for ccdb encryption key rotation - #5476
Open
jochenehret wants to merge 1 commit into
Open
jochenehret wants to merge 1 commit into
jochenehret wants to merge 1 commit into
Conversation
* new task to check if re-encryption is necessary, call with "rake rotate_cc_database_key:check" ** exit code 0: no rows need to be re-encrypted ** exit code 1: error ** exit code 2: rows need re-encryption -> now you must run "rake rotate_cc_database_key:perform", or the corresponding bosh errand
3 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
New Rake task to check if re-encryption is necessary.
exit code 0: no rows need to be re-encrypted
exit code 1: error
exit code 2: rows need re-encryption -> now you must run "rake rotate_cc_database_key:perform", or the corresponding bosh errand
Currently we are always calling the
rotate_cc_database_keyerrand in our CI pipeline. This errand is configured to run on a separate VM and sometimes VM creation fails due to capacity shortages. Co-locating the errand on an existing VM is not a solution, as the errand is long-running and would block BOSH updates.So we are proposing a new Rake task that allows to check if rotation is necessary or can be skipped.
cloudfoundry/capi-release#696
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests