Skip to content

fix: cloud_controller_ng#4971 #5026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
b1tamara wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Draft

fix: cloud_controller_ng#4971 #5026

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions app/actions/manifest_route_update.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,16 @@ def update(app_guid, message, user_audit_info)
app_guid => app
}
routes_to_map = []
current_route = nil

message.manifest_route_mappings.each do |manifest_route_mapping|
current_route = manifest_route_mapping[:route].to_s
route = {
model: find_or_create_valid_route(app, manifest_route_mapping[:route].to_hash, user_audit_info),
protocol: manifest_route_mapping[:protocol]
}

raise InvalidRoute.new("No domains exist for route #{manifest_route_mapping[:route]}") if route[:model].blank?
raise InvalidRoute.new("No domains exist for route #{current_route}") if route[:model].blank?

routes_to_map << route
end
Expand Down Expand Up @@ -53,7 +55,8 @@ def update(app_guid, message, user_audit_info)
end
end
rescue Sequel::ValidationFailed, RouteCreate::Error, RouteUpdate::Error => e
raise InvalidRoute.new(e.message)
route_info = current_route ? "For route '#{current_route}': " : ''
raise InvalidRoute.new("#{route_info}#{e.message}")
end

private
Expand Down
Loading