fix doc: metadata.annotations keys should not allow spaces#5013
Open
peterhaochen47 wants to merge 1 commit intocloudfoundry:mainfrom
Open
fix doc: metadata.annotations keys should not allow spaces#5013peterhaochen47 wants to merge 1 commit intocloudfoundry:mainfrom
peterhaochen47 wants to merge 1 commit intocloudfoundry:mainfrom
Conversation
peterhaochen47
changed the title
peterhaochen47
force-pushed
the
pr/main/fix-doc-label-key-april926
branch
from
5b4f97a to
82fb28d
Compare
- the validation logic in app/messages/metadata_validator_helper.rb does not allow spaces in keys - added a relevant test case - fixed the examples provided in doc
peterhaochen47
force-pushed
the
pr/main/fix-doc-label-key-april926
branch
from
82fb28d to
5c3080d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
An explanation of the use cases your change solves
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests