Skip to content

brats: fix upgrade from postgres 13 test - #2804

Merged
mkocher merged 2 commits into
mainfrom
resolute-pipeline
Aug 14, 2026
Merged

brats: fix upgrade from postgres 13 test#2804
mkocher merged 2 commits into
mainfrom
resolute-pipeline

Conversation

@mkocher

@mkocher mkocher commented Aug 14, 2026

Copy link
Copy Markdown
Member

What is this change about?

Postgres 10 does not compile on Resolute. This test was pulling in a version of postgres 13 that itself pulled in Postgres 10 for upgrade purposes. Switching to a version where postgres 13 does not include postgres 10.

What tests have you run against this PR?

I've manually validated the steps this test goes through using the manifests from the repo.

Does this PR introduce a breaking change?

No

- this is necessary to get brats passing on Resolute
- it's ok for it to run under BPM on all stemcell lines, since we're
  controlling the manifest and there will not be other copies of BPM to
  conflict
- up the compile timeout a little, hopefully 30 minutes is enough even when
  when CI is overloaded
Postgres 10 does not compile on Resolute. This test was pulling in a version of
postgres 13 that itself pulled in Postgres 10 for ugprade purposes. Switching
to a version where postgres 13 does not include postgres 10.
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: bdc20b1e-f116-4ee2-b97e-e3df9d0f30e6

📥 Commits

Reviewing files that changed from the base of the PR and between 7d357db and 58b4a04.

📒 Files selected for processing (5)
  • ci/shared/brats/test-acceptance.yml
  • src/brats/acceptance/blobstore_test.go
  • src/brats/assets/postgres-13-manifest.yml
  • src/brats/assets/syslog-manifest.yml
  • src/brats/utils/utils.go

Walkthrough

The default inner BOSH startup timeout increased from 25 minutes to 30 minutes. The PostgreSQL 13 manifest now uses the postgres-13 job and BOSH release 283.1.4. The syslog manifest now declares the BPM release and enables BPM for syslog_forwarder. Three blobstore acceptance scenarios now upload updated syslog and BPM releases.

Merge Risk: ⚪ Minimal · up to 58b4a

This localized test and manifest update changes which PostgreSQL version is used for upgrade coverage without introducing an actionable merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: fixing the BRATS PostgreSQL 13 upgrade test.
Description check ✅ Passed The description explains the change, validation performed, and breaking-change status, but omits several template sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch resolute-pipeline

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@aramprice

Copy link
Copy Markdown
Member

This upcoming test addition might be worth cribbing from
=> #2779

@mkocher
mkocher merged commit 6368bf5 into main Aug 14, 2026
22 checks passed
@mkocher
mkocher deleted the resolute-pipeline branch August 14, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants