Closed
Conversation
Ruby 3.4+ will remove syslog from the standard library. Explicitly adding it to Gemfile to silence deprecation warnings.
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
beyhan
moved this from Inbox
to Pending Review | Discussion
in Foundational Infrastructure Working Group
aramprice
requested changes
Feb 6, 2026
Member
aramprice
left a comment
aramprice
left a comment
There was a problem hiding this comment.
This change looks fine though I'd rather not add a transitive dependency to our Gemfile if we can help it.
This appears to be coming from the logging gem which has a guard around the loading of syslog[1] so I think we are ok w/o this change.
[1] https://github.com/TwP/logging/blob/master/lib/logging.rb#L9-L14
If this is annoying enough that we do want to make this addition to the Gemfile, let's move it next to where we specify
spec.add_dependency 'logging'in the gemspec files with a comment noting that the dependency is there because of logging.
github-project-automation
bot
moved this from Pending Review | Discussion
to Waiting for Changes | Open for Contribution
in Foundational Infrastructure Working Group
Member
Author
|
Hi @aramprice, Thank you for looking into this! I don't see a reason to add it since the logging gem is already handling it. The warnings should stop appearing once we move to Ruby 3.4+. |
github-project-automation
bot
moved this from Waiting for Changes | Open for Contribution
to Done
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes care of the following error and any potential issues when we move to Ruby 3.4+: