Fix undefined method detached? for String#2662
Merged
Conversation
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
aramprice
previously approved these changes
Feb 4, 2026
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
aramprice
reviewed
Feb 4, 2026
aramprice
force-pushed
the
fix_detached_method_used_on_string
branch
2 times, most recently
from
c6d4667 to
742f265
Compare
- Remove unnecessary check in already_detached? method - Fix instance state checks to use constants instead of methods - Hoist constants out to Bosh::Director - resurrect attr_accessor's in instance_group.rb - replace magic array's of strings with arrays of constants
aramprice
force-pushed
the
fix_detached_method_used_on_string
branch
from
742f265 to
5b7d500
Compare
Member
|
@neddp - thank you for catching the cases I missed, apologies for the noise! I pushed some additional changes - mostly moving the constants up to |
aramprice
approved these changes
Feb 5, 2026
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on PR #2659 which broke the integration tests for BOSH:
instance.state.detached?is called, butinstance.statereturns a String (not a StringInquirer), so it doesn't have the.detached?method.Changes
DeploymentPlan::Instance:STATE_STARTED,STATE_STOPPED,STATE_DETACHEDDeploymentPlan::Instance:started?,stopped?,detached?attr_accessordeclarations ininstance_group.rb