Open
Conversation
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
beyhan
requested review from
a team,
julian-hj and
mkocher
and removed request for
a team
beyhan
moved this from Inbox
to Pending Review | Discussion
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this change about?
This PR adds
nic_groupsupport for VIP networks in the BOSH Director, enabling operators to specify which network interface should receive an Elastic IP when deploying instances with multiple NICs.When a VIP network includes a
nic_groupproperty, the Director now passes this information to the CPI in the network settings, allowing the CPI to associate the Elastic IP with the correct network interface.Please provide contextual information.
This change works in conjunction with the AWS CPI PR that implements the
nic_grouptodevice_indexmapping logic.Changes:
VipNetwork#network_settingsto includenic_groupwhen specifiednic_groupis converted to string format for CPI consumptionnic_groupwhen not specifiedWhat tests have you run against this PR?
How should this change be described in bosh release notes?
VIP networks now support the
nic_groupproperty in deployment manifests. When specified, the Director passes this value to the CPI to control which network interface receives an Elastic IP in multi-NIC configurations.Does this PR introduce a breaking change?
No. This change is backward compatible. When
nic_groupis not specified on a VIP network, the property is omitted from the network settings sent to the CPI, maintaining existing behavior.