fix: application not starting due to wrong usage of loggerContext#149
Merged
rspiegl merged 1 commit intocloudflightio:masterfrom Jun 18, 2025
Merged
fix: application not starting due to wrong usage of loggerContext#149rspiegl merged 1 commit intocloudflightio:masterfrom
rspiegl merged 1 commit intocloudflightio:masterfrom
Conversation
JohannesRiegler
commented
Jun 17, 2025
|
|
||
| public LengthSplittingAppender() { | ||
| super(); | ||
| LoggerContext loggerContext = (LoggerContext) LoggerFactory.getILoggerFactory(); |
Contributor
Author
There was a problem hiding this comment.
this call will run before the logger context is initialised and will case a startup failure
rspiegl
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My previous "fix" in #146 actually breaks application startup if used in a kubernetes Context.
During startup the loggerContext is not yet initialised and the
(LoggerContext) LoggerFactory.getILoggerFactory()call returns a SubstituteLoggerFactory which breaks when trying to cast to a LoggerContext.I tried to replicate the Environment in a test but i could not find a good solution even with junit-pioneer or system-stubs