Conversation
We added --allow-build but this is broken because if version 1.0 of pkg-a is available from pyodide-index but version 1.1 is on pypyi and 1.1 has no emscripten wheel, with --allow-build will try and fail to build 1.1 from pypi rather than installing 1.0 from the pyodide index. This just takes note of which packages are local paths and allows building exactly those.
hoodmane
force-pushed
the
hoodmane/build-local-paths
branch
from
September 18, 2026 20:21
f14ae80 to
d2add47
Compare
ryanking13
approved these changes
Sep 21, 2026
| default=None, | ||
| help=( | ||
| "Allow building source distributions and local directory sources. " | ||
| "Allow building any source distribution, not just local path sources. " |
Contributor
There was a problem hiding this comment.
not just local path sources. part looks unnecessary, and sound like AI.
| testlib = { path = "../testlib/dist/testlib-0.0.0-py3-none-any.whl" } | ||
| django-cf = { path = "../packages/django-cf" } | ||
| testlib = { path = "../packages/testlib" } | ||
| workers-runtime-sdk = { path = "../packages/runtime-sdk" } |
Contributor
There was a problem hiding this comment.
Nice to see that this works now!
Comment on lines
+84
to
+85
| # These are deployable example apps, so their pyproject.toml depends on the | ||
| # released django-cf from PyPI. Tests must exercise the working tree instead. |
Contributor
There was a problem hiding this comment.
Yeah, we should split the templates and the unittests.
Comment on lines
+136
to
+139
| Unlike the app fixtures above, the worker's pyproject.toml depends on the | ||
| working-tree django-cf, runtime-sdk and testlib via ``../packages/...`` | ||
| path sources, which the ``packages`` symlink makes resolvable, so ``sync`` | ||
| vendors them directly. |
Contributor
There was a problem hiding this comment.
This comment now looks unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added --allow-build but this is broken because if version 1.0 of pkg-a is
available from pyodide-index but version 1.1 is on pypyi and 1.1 has no
emscripten wheel, with --allow-build will try and fail to build 1.1 from pypi
rather than installing 1.0 from the pyodide index.
This just takes note of which packages are local paths and allows building
exactly those.