chore: test django with WSGI - #163
Conversation
|
I've completed my review. The PR is well-structured. The changes consolidate LGTM |
There was a problem hiding this comment.
renamed to /django/src/test_caching.py. It seems like github is not smart enough to detect renaming on this file.
There was a problem hiding this comment.
Same. renamed to /django/src/test_streaming.py.
|
|
||
|
|
||
| class CustomAsyncMiddleware: | ||
| class CustomMiddleware: |
There was a problem hiding this comment.
Making this middleware work on both sync and async mode.
There was a problem hiding this comment.
django's async and sync views need to be registered differently. The only difference between urls.py and urls_sync.py is that whether the views are synchronous or asynchronous (async def vs def)
Run the same django test suite that I added in #147 with wsgi.py